Skip to content

trusted-execution-clusters: no skip_if_only_changed - #83428

Open
Jakob-Naucke wants to merge 1 commit into
openshift:mainfrom
Jakob-Naucke:tec-always-run
Open

trusted-execution-clusters: no skip_if_only_changed#83428
Jakob-Naucke wants to merge 1 commit into
openshift:mainfrom
Jakob-Naucke:tec-always-run

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Aug 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Overrides always_run: false, leading to unsolicited runs on PRs such as trusted-execution-clusters/operator#337. The burden is on the reviewer to not trigger a test in these no-test-impact cases.

if I'm interpreting https://docs.ci.openshift.org/architecture/ci-operator/#pre-submit-tests right:

always_run: Set to false to disable automatic triggering on every PR. This defaults to true (run on every PR) unless run_if_changed or skip_if_only_changed is set.

Summary by CodeRabbit

The Azure trusted-execution-clusters operator no longer uses skip_if_only_changed for integration-test. This prevents documentation-only or metadata-only changes from overriding always_run: false and starting tests automatically. Reviewers must trigger tests when required.

@Jakob-Naucke
trusted-execution-clusters: no skip_if_only_changed
81d3bce 
Overrides `always_run: false`, leading to unsolicited runs on PRs such
as trusted-execution-clusters/operator#337.
The burden is on the reviewer to not trigger a test in these
no-test-impact cases.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ef409ff3-18cb-494e-8a53-3e361c504ffd

📥 Commits

Reviewing files that changed from the base of the PR and between 2934193 and 81d3bce.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main__azure.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main__azure.yaml

Walkthrough

The Azure integration test configuration no longer skips tests when changes are limited to documentation, metadata, or listed repository files.

Changes

Integration Test Trigger

Layer / File(s) Summary
Remove path-based skip condition
ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main__azure.yaml		 The integration-test configuration no longer defines skip_if_only_changed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 81d3b

This change prevents unnecessary presubmit runs when the repository changes do not affect tests; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the trusted-execution-clusters configuration change to remove skip_if_only_changed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff only removes YAML skip_if_only_changed entries; it changes no Ginkgo test source or test title, so this check has no applicable failure.
Test Structure And Quality ✅ Passed The parent-to-HEAD diff changes only two CI YAML files and removes skip_if_only_changed; it introduces no Ginkgo It blocks or cluster-test setup, waits, or assertions.
Microshift Test Compatibility ✅ Passed The commit changes only CI YAML metadata and removes skip rules; it adds no Ginkgo tests or references to MicroShift-incompatible APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull-request diff changes only CI YAML files and adds no Go or Ginkgo e2e tests, so SNO compatibility criteria do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only removes skip_if_only_changed from CI config and its generated presubmit job; it adds no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The pull request changes only two YAML CI configuration files and adds no OTE binary or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff only removes skip_if_only_changed from CI YAML and the generated presubmit job; it adds no Ginkgo tests or network connectivity.
No-Weak-Crypto ✅ Passed The diff only removes skip_if_only_changed from CI configuration and its generated presubmit job; it introduces no weak crypto or secret-comparison code.
Container-Privileges ✅ Passed The diff only removes skip_if_only_changed from two YAML files; it introduces no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff only removes scheduling filters from two YAML files; the changed-line scan found no logging or sensitive-data output, and the referenced secret-handling script is unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from alicefr and deepsm007 August 14, 2026 10:48
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jakob-Naucke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2026
@openshift-merge-bot

openshift-merge-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Jakob-Naucke: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-trusted-execution-clusters-operator-main-azure-integration-test trusted-execution-clusters/operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@Jakob-Naucke: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alicefr alicefr Awaiting requested review from alicefr
@deepsm007 deepsm007 Awaiting requested review from deepsm007

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jakob-Naucke